Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sizeof() Terminated raises an error instead of returning 0 #1067

Open
johnranson opened this issue Jan 29, 2024 · 1 comment
Open

sizeof() Terminated raises an error instead of returning 0 #1067

johnranson opened this issue Jan 29, 2024 · 1 comment

Comments

@johnranson
Copy link

Per the docstring, "Size is defined as 0" for Terminated, but _sizeof simply raises an error.

I use sizeof in assert statements to verify that my Structs are exactly the length expected. If I include Terminated in a Struct, I get a SizeofError.

@jpsnyder
Copy link

sizeof() broken in many different ways in construct.

I would just patch your code.

def _sizeof(self, context, path):
    return 0

construct.Terminated._sizeof = _sizeof

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants