Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timestamps in query key can trigger infinite query loops #361

Closed
paul-sachs opened this issue Apr 29, 2024 · 1 comment · Fixed by #366
Closed

Timestamps in query key can trigger infinite query loops #361

paul-sachs opened this issue Apr 29, 2024 · 1 comment · Fixed by #366

Comments

@paul-sachs
Copy link
Collaborator

Using the following query will cause an infinite loading query:

import { Timestamp } from "@bufbuild/protobuf";
...
useSuspenseQuery(
  someMethod,
  {
    start: Timestamp.fromDate(new Date("01/01/01")),
    end: Timestamp.fromDate(new Date("02/01/01"))
  }
);

This is likely due to the handling of class objects in stable-hash.

@paul-sachs
Copy link
Collaborator Author

Fixed in 1.4.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant