Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include prebuilt executables in releases #695

Open
andrew-womeldorf opened this issue Feb 20, 2024 · 3 comments · May be fixed by #696
Open

Include prebuilt executables in releases #695

andrew-womeldorf opened this issue Feb 20, 2024 · 3 comments · May be fixed by #696
Assignees
Labels
enhancement New feature or request

Comments

@andrew-womeldorf
Copy link

Is your feature request related to a problem? Please describe.
In order to buf generate, my environment must have go installed so that I can first install protoc-gen-connect-go.

Describe the solution you'd like
Include prebuilt executables with releases.

Describe alternatives you've considered
Install go and use go install... 😄

Additional context
This is certainly a convenience request. My current situation is trying to create more efficient CI jobs. I can download protoc-gen-go and buf without needing to bloat the build environment by installing go and associated tools. It would be nice to be able to simply download an executable for protoc-gen-connect-go as well.

@andrew-womeldorf andrew-womeldorf added the enhancement New feature or request label Feb 20, 2024
@emcfarlane
Copy link
Contributor

emcfarlane commented Feb 20, 2024

It's usually assumed to use and build the libraries go would be required locally. Install can be done with:

go install connectrpc.com/connect/cmd/protoc-gen-connect-go@latest

As an alternative you can use remote code generation using buf. This doesn't require you to manage the plugin binaries locally. See the docs here for more details: https://buf.build/docs/bsr/remote-plugins/usage#4.4.-connect-go

Release binaries would be a nice addition though. I'll let others weigh in but I agree with this proposal.

@akshayjshah
Copy link
Member

I agree that release binaries would be nice, even if they're unnecessary for people using the buf CLI. @emcfarlane Can we look into integrating GoReleaser in this repo?

@andrew-womeldorf
Copy link
Author

As an alternative you can use remote code generation using buf. This doesn't require you to manage the plugin binaries locally. See the docs here for more details: https://buf.build/docs/bsr/remote-plugins/usage#4.4.-connect-go

Oh, awesome. This worked great. I didn't realize that I could do this. Thank you!

@emcfarlane emcfarlane linked a pull request Feb 21, 2024 that will close this issue
@emcfarlane emcfarlane self-assigned this Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants