Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade bigquery to version 1.119.0 #59

Closed
mubeen opened this issue Nov 27, 2020 · 4 comments
Closed

Upgrade bigquery to version 1.119.0 #59

mubeen opened this issue Nov 27, 2020 · 4 comments

Comments

@mubeen
Copy link

mubeen commented Nov 27, 2020

Hi,

I am currently experiencing an issue whereby version 1.79.0 of the google-cloud-bigquery artefact only supports partitioning against the DAY partitioning type, this has been resolved in version 1.119.0 of the artefact.

Is there a way to upgrading the version to 1.119.0 to get the support all of the partitioning types? Are there concerns that I need to be aware of that has prevented the upgrade to later version of this library?

Thanks in advance.

@C0urante
Copy link

Did some digging, looks like partitioning by hour was added in googleapis/java-bigquery#336 and first released with version 1.114.0, and partitioning by month and year was added in googleapis/java-bigquery#737 and first released with version 1.119.0.

@mubeen I can't say with certainty that upgrading from 1.79.0 to 1.119.0 wouldn't break anything, but if Google follows semantic versioning with their BigQuery Java SDK, the only risk would be from bugs introduced by new features (as opposed to breaking changes). I wouldn't be opposed to bumping the version the connector uses as long as we can confirm that that's the case, and do some testing of our own against that new version to make sure that no obvious bugs would be introduced with it.

However, I'm not sure that we'd get much from just bumping the version; we'd also have to make changes to the connector itself if we wanted to add the same support for non-day partitioning types that we have at the moment for day-based partitioning. I'd be happy to review a PR to do that (or review a design proposal if one is warranted) if you or anyone else would like to implement those changes.

@mubeen
Copy link
Author

mubeen commented Dec 3, 2020

Hi @C0urante I have created a pull request, could you please review the PR

@mubeen
Copy link
Author

mubeen commented Dec 8, 2020

Hi @C0urante new pull requested created against master as requested.

@C0urante
Copy link

Addressed via #61

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants