Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parallel test runs #120

Closed
wants to merge 4 commits into from
Closed

Parallel test runs #120

wants to merge 4 commits into from

Conversation

ethanfrey
Copy link
Member

Closes #89

This works faster but has 2 issues:

  • Since test cases run in separate processes, the mutex only prevents conflicts within one file. We need to see how to prevent conflicts between files
  • Sinon doesn't work to well in these parallel situations. (remove .serial from the binary tests to see this)

@ethanfrey ethanfrey added this to In progress in Relayer via automation Mar 15, 2021
@willclarktech
Copy link
Contributor

Sinon doesn't work to well in these parallel situations.

Without looking into this my guess is we can solve whatever the problem is with sandboxes: https://sinonjs.org/releases/v9.2.4/sandbox/

@webmaster128
Copy link
Member

Looking at #254, can we close this?

@ethanfrey
Copy link
Member Author

Let's close the PR for sure.

Maybe revisit the issue with the new framework (which must run everything sequentially at first until we refactor the startup code)

@ethanfrey ethanfrey closed this Oct 20, 2022
Relayer automation moved this from In progress to Done Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
No open projects
Relayer
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve test suite
3 participants
@ethanfrey @willclarktech @webmaster128