Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use newer / more common test framework #254

Open
ethanfrey opened this issue Oct 13, 2022 · 2 comments
Open

Use newer / more common test framework #254

ethanfrey opened this issue Oct 13, 2022 · 2 comments

Comments

@ethanfrey
Copy link
Member

nyc/ava is a relic of a previous dev, but no one uses it.

We cannot use watch tests anyway with this codebase, as they run a minute or so full relayer tests.

We could migrate to something more common. And ideally that gives better stack traces on errors
@webmaster128
Copy link
Member

jest is very common (and has test watching). In CosmJS we still use Jasmine because in contrast to jest it runs well in the browser.

Both share the same syntax.

@ethanfrey
Copy link
Member Author

We have no need to watching.
I am not sure if we care much about the browser use case, but I consider it a nice to have

Either jasmine or jest seem reasonable. Happy for a pr to either one.

@webmaster128 webmaster128 mentioned this issue Oct 19, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@webmaster128 @ethanfrey