Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor poe/ contract/ BondDelegation method signature #313

Open
alpe opened this issue Mar 22, 2022 · 1 comment
Open

Refactor poe/ contract/ BondDelegation method signature #313

alpe opened this issue Mar 22, 2022 · 1 comment
Labels
non_breaking
Milestone
Tgrade - "Post Ma...

Comments

@alpe
Copy link
Contributor

alpe commented Mar 22, 2022

Replace vestingAmount *sdk.Coin by vestingAmount sdk.Coin type in BondDelegation and check with !vestingAmount.IsNil() && !vestingAmount.IsZeor() when set.

Follow up from #303 (comment)
@alpe alpe added the good first issue Good for newcomers label Mar 22, 2022
@alpe alpe mentioned this issue Mar 22, 2022
Merged
@alpe alpe added this to the Tgrade - "Post Mainnet" milestone May 10, 2022
@alpe alpe added non_breaking and removed good first issue Good for newcomers labels Jul 7, 2022
@alpe
Copy link
Contributor Author

alpe commented Jul 7, 2022

This is an internal refactoring that should not affect external or contract apis, neither state

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
non_breaking
Projects
None yet
Milestone
Tgrade - "Post Mainnet"
Development

No branches or pull requests
1 participant
@alpe