Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test gov proposal contracts and mappings #291

Open
alpe opened this issue Mar 1, 2022 · 2 comments
Open

Test gov proposal contracts and mappings #291

alpe opened this issue Mar 1, 2022 · 2 comments
Labels
M Medium task, 1-3 days work non_breaking

Comments

@alpe
Copy link
Contributor

alpe commented Mar 1, 2022

We need an integration test for all all supported gov proposal types.

  1. Create a proposal in the the related contract
  2. Vote + execute
  3. Capture the response and convert into TgradeMsg
  4. Ensure the relevant fields are set with the expected data

Goal is to ensure that the contract response object matches the expected mappings in tgrade. There were some issues in the past where the msg field had different name like migrate_msg

@alpe alpe changed the title Test gov proposals Test gov proposal contracts and mappings Mar 1, 2022
@alpe alpe added this to the Tgrade 0.7 - "dryrun net" milestone Mar 1, 2022
@BirgitPohl BirgitPohl changed the title Test gov proposal contracts and mappings Picked: Test gov proposal contracts and mappings Mar 9, 2022
@daniellarita daniellarita added the Ready for Refinement A well define issue that is ready for refinement label Mar 9, 2022
@BirgitPohl
Copy link

I would split this task into 4. It makes it easier to review later. A review comes with less human errors.

@daniellarita daniellarita changed the title Picked: Test gov proposal contracts and mappings Test gov proposal contracts and mappings Mar 14, 2022
@alpe
Copy link
Contributor Author

alpe commented Mar 24, 2022

All 4 steps should be implemented into the same integration test.
first one is setup system under test, second is to run the test case, last two are verifying assumptions.
To split this into multiple tasks then you could go by proposal although they all for a contract may all go into the same table test and can not be worked on in parallel.
We have voting with OC, AP and validator community. They are more or less independent.
We have some coverage for the validator community voting already in https://github.com/confio/tgrade/blob/main/x/poe/contract/tgrade_validator_voting_integration_test.go#L27

@alpe alpe removed the Ready for Refinement A well define issue that is ready for refinement label Jun 7, 2022
@alpe alpe added the M Medium task, 1-3 days work label Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
M Medium task, 1-3 days work non_breaking
Projects
None yet
Development

No branches or pull requests

3 participants