Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust ConfiguConfigStore for the Approval Queue feature #343

Open
2 of 4 tasks
RichardAkman opened this issue Jan 18, 2024 · 0 comments · Fixed by #344 or #352
Open
2 of 4 tasks

Adjust ConfiguConfigStore for the Approval Queue feature #343

RichardAkman opened this issue Jan 18, 2024 · 0 comments · Fixed by #344 or #352
Labels
feat New feature or request sdk alignment This issue need implementation for all SDKs

Comments

@RichardAkman
Copy link
Contributor

RichardAkman commented Jan 18, 2024 •
edited

Suggestion

The ConfiguConfigStore class set method currently doesn't acknowledge that configs might not have been mutated but instead inserted into an approval queue for admin review. To indicate to users of the store, the method should throw an exception in this scenario.

Motivation

Improved UX and clarity to users of ConfiguConfigStore

Tasks

  • TS SDK implementation
  • CLI implementation
  • Python SDK implementation
  • Go SDK implementation
@RichardAkman RichardAkman added the chore General codebase work label Jan 18, 2024
@RichardAkman RichardAkman self-assigned this Jan 18, 2024
@RichardAkman RichardAkman mentioned this issue Jan 18, 2024
Merged
@RichardAkman RichardAkman linked a pull request Jan 18, 2024 that will close this issue
Adjust @configu/ts - ConfiguConfigStore for the Approval Queue feature #344
Merged
@RichardAkman RichardAkman added feat New feature or request and removed chore General codebase work labels Jan 18, 2024
@RichardAkman RichardAkman changed the title Adjust ConfiguConfigStore for the Approval Queue feature Adjust ConfiguConfigStore for the Approval Queue feature Jan 25, 2024
@RichardAkman RichardAkman reopened this Feb 5, 2024
@RichardAkman RichardAkman mentioned this issue Feb 5, 2024
Merged
@RichardAkman RichardAkman reopened this Feb 6, 2024
@RichardAkman RichardAkman removed their assignment Feb 15, 2024
@RichardAkman RichardAkman added the sdk alignment This issue need implementation for all SDKs label Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feat New feature or request sdk alignment This issue need implementation for all SDKs
Projects
None yet
Milestone
No milestone
1 participant
@RichardAkman