Catch PackageNotFoundError for DependencyNeedsBuildingError
#5257
Conversation
Partially reverts conda@7acbbf2 Signed-off-by: Marcel Bargull <marcel.bargull@udo.edu>
conda-bot
added
the
cla-signed
|
Needs regression test and news entry. |
| except ( | ||
| NoPackagesFoundError, | ||
| UnsatisfiableError, | ||
| PackagesNotFoundError, |
There was a problem hiding this comment.
@kenodegard, why did we had this change in 7acbbf2 ?
Re-adding PackagesNotFoundError fixes gh-5256. Am I missing something?
There was a problem hiding this comment.
I had added it in the prior commit (7539a73) as I was trying to debug a weird error (see 7acbbf2#r1517170310)
Since the fix had nothing to do with catching PackagesNotFoundError I removed it again
See the full diff for conda_buid.environ https://github.com/conda/conda-build/pull/5203/files#diff-3ba52da5dde963be464da17aa3a40b91541d9709735c97fd03b59d3a0fb54a78R32-R55 doesn't include PackagesNotFoundError before or after
There was a problem hiding this comment.
Ah, I landed at 7acbbf2 as the first commit to show the regression but didn't realize that was an intermediate change. Thanks, that's very helpful.
Since 4da3bce works, there must be something in ca792ee (with the get_install_actions name dance applied) that causes it, I think. Let me dig into those changes a bit..
There was a problem hiding this comment.
Oh, I guess 24.1 didn't show this because d7a9751 broke the "get_install_actions is in the last N entries on the stack" assumption of conda-libmamba-solver.
Meaning, conda-build<24.1 also didn't handle these errors correctly and in fact conda-build=24.1 broke conda-libmamba-solver setting context.offline...
There was a problem hiding this comment.
Do we need to adjust anything in conda-libmamba-solver?
CodSpeed Performance ReportMerging #5257 will not alter performanceComparing Summary
|
| @@ -965,7 +966,11 @@ def get_install_actions( | |||
| with capture(): | |||
| try: | |||
| precs = _install_actions(prefix, index, specs)["LINK"] | |||
| except (NoPackagesFoundError, UnsatisfiableError) as exc: | |||
| except ( | |||
| NoPackagesFoundError, | |||
There was a problem hiding this comment.
We may want to use the non-aliased ResolvePackageNotFound here for clarification.
(conda.exceptions/conda.exports sets NoPackagesFound = NoPackagesFoundError = ResolvePackageNotFound.)
Description
Partially reverts
7acbbf2
Fixes gh-5256.
Checklist - did you ...
newsdirectory (using the template) for the next release's release notes?