New repo URL breaks existing workflows

[jaimergp]

I would have expected runners to follow redirections for actions that have changed location, but they don't...

https://github.com/openforcefield/openforcefield/runs/1114396909?check_suite_focus=true

Thanks to @mattwthompson for the report!

[goanpeca]

Hi @jaimergp, yes I was expecting the redirects to last longer :-|

[mattwthompson]

It does seem to be working as expected after manually updating it: https://github.com/openforcefield/openforcefield/actions/runs/254560374

[goanpeca]

Thanks for the report @mattwthompson, leaving open as this will probably bite more people :-|

[jaimergp]

Are all users expected to manually migrate though? Maybe you can post the last version to your goanpeca namespace too, but adding a warning that it's changing locations and that the repo won't receive any more updates?

[goanpeca]

Are all users expected to manually migrate though? Maybe you can post the last version to your goanpeca namespace too, but adding a warning that it's changing locations and that the repo won't receive any more updates?

Yep that would have been a better path 😆

I do not have time to do this at the moment so I will just create a fork and add a warning later when time clears a bit.

Thanks for the suggestion.

[goanpeca]

Created this fork, so I guess this should bring it back to life ?

https://github.com/goanpeca/setup-miniconda

[jaimergp]

Thank you so much for the fast response! That will do in the meantime, yes!

[jaimergp]

I also raised this through their Twitter support and they are looking into it:

https://twitter.com/jaime_rgp/status/1305620040595763204

[jaimergp]

Github support has theoretically addressed this: https://twitter.com/mscccc/status/1306002367175823360

I don't know what we should do now, though:

a) Remove the fork and hope the redirection works
b) Keep the fork but add a deprecation warning pointing to the new URL

[goanpeca]

I would favor b :-)

That would be the nice thing to do.

Thoughts @conda-incubator/setup-miniconda-team ?

Now for how long would redirects work?

[jaimergp]

I would favor b :-)

Agreed!

Now for how long would redirects work?

As far as I know, they shouldn't expire? source

[goanpeca]

Let's keep the fork for now while we add the new things.

[bollwyvl]

On account of #84, you'll probably want to upgrade to v2 anyhow...

[goanpeca]

Just made release 2.2.0, and updated the fork as well. We should be safe now to close the fork and close this issue @jaimergp, @jezdez ?

See https://github.com/search?q=goanpeca%2Fsetup-miniconda&type=code for users still using the old repo

[goanpeca]

I believe this is safe to close, updated release instructions (82400b0) to include an update to the fork and gave @jaimergp and @jezdez access to https://github.com/goanpeca/setup-miniconda just in case :)