Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The add-path command and set-env command is disabled #101

Closed
bradyrx opened this issue Nov 17, 2020 · 11 comments
Closed

The add-path command and set-env command is disabled #101

bradyrx opened this issue Nov 17, 2020 · 11 comments
Labels
reso:duplicate This issue or pull request already exists type:bug Something isn't working

Comments

@bradyrx
Copy link

bradyrx commented Nov 17, 2020

SOLUTION: Simply update your goanpeca/setup-miniconda@v1 hook to conda-incubator/setup-miniconda@v2 and the error should go away.


It looks like something changed to Github Actions today, as our setup-miniconda hook is breaking with the following error:

Add "/usr/share/miniconda/condabin" to PATH
Error: Unable to process command '::add-path::/usr/share/miniconda/condabin' successfully.
Error: The `add-path` command is disabled. Please upgrade to using Environment Files or opt into unsecure command execution by setting the `ACTIONS_ALLOW_UNSECURE_COMMANDS` environment variable to `true`. For more information see: https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/
/usr/share/miniconda/condabin/conda config --add pkgs_dirs /home/runner/conda_pkgs_dir
Error: Unable to process command '::set-env name=CONDA_PKGS_DIR::/home/runner/conda_pkgs_dir' successfully.
Error: The `set-env` command is disabled. Please upgrade to using Environment Files or opt into unsecure command execution by setting the `ACTIONS_ALLOW_UNSECURE_COMMANDS` environment variable to `true`. For more information see: https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/

See our error in more detail here.

And the workflow code here.

I found that this is affecting other hooks, so I imagine it must be a Github Actions change. E.g., camerahub/camerahub#630, apache/tvm#6925.


EDIT: Actually it looks like GA announced this back in October, but went into effect today.

@jaimergp
Copy link
Member

See #99.

@bradyrx
Copy link
Author

bradyrx commented Nov 17, 2020

Agh, sorry, thought I was ahead of the curve here. Appreciate you guys addressing it so fast!

@goanpeca
Copy link
Member

goanpeca commented Nov 17, 2020

Hi @bradyrx thanks for the report. Indeed a duplicate of #99

@jaimergp we could live this open (cause this one already has the duplicated context) and tag it on the issue tracker? Maybe that way is easier to find for otrher users?

@goanpeca goanpeca added reso:duplicate This issue or pull request already exists type:bug Something isn't working labels Nov 17, 2020
@jaimergp jaimergp reopened this Nov 17, 2020
@jaimergp
Copy link
Member

Oh, sure, nice idea. There might be more reports coming. Shall we also pin it for a week or so?

@goanpeca goanpeca pinned this issue Nov 17, 2020
@goanpeca
Copy link
Member

goanpeca commented Nov 17, 2020

Yep, just pinned it :)

Screen Shot 2020-11-17 at 11 16 21

@jaimergp
Copy link
Member

@bradyrx Can you add a little comment on your opening message stating the solution for visibility?

@jaimergp
Copy link
Member

Yep, just pinned it :)

Dark GitHub feels wrong 😄

@bradyrx
Copy link
Author

bradyrx commented Nov 17, 2020

Done, thanks guys! Easy fix and quick communication.

@valeriupredoi
Copy link

cheers, guys! will buy pints if this works well for us too 🍺

@valeriupredoi
Copy link

cheers, guys! will buy pints if this works well for us too beer

it works very well with the new hooks - much appreciated, folks here! 🍺

@goanpeca
Copy link
Member

Closing this one, I think we should be fine moving forward :)

mnavascues added a commit to mnavascues/ABC_TimeAdapt that referenced this issue Nov 12, 2021
@goanpeca goanpeca unpinned this issue Nov 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
reso:duplicate This issue or pull request already exists type:bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants