Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add recipe for squadgen #26335

Merged
merged 4 commits into from May 13, 2024
Merged

Add recipe for squadgen #26335

merged 4 commits into from May 13, 2024

Conversation

xylar
Copy link
Contributor

@xylar xylar commented May 12, 2024

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/squadgen) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/squadgen:

  • License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

@xylar
Copy link
Contributor Author

xylar commented May 12, 2024

Note: this library includes the source for the legacy NetCDF C++ library, but it doesn't create a library of its own, just an executable. The license file has been included.

@xylar
Copy link
Contributor Author

xylar commented May 12, 2024

@conda-forge/help-c-cpp, ready for review!

@xylar
Copy link
Contributor Author

xylar commented May 12, 2024

@ocefpaf, another one that you might be willing to have a look at? Also, if you understand what I've done that is causing libpng to be linked statically rather than dynamically, let me know. I'm not super expert in CMake yet...

Copy link
Member

@xhochy xhochy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe try BUILD_SHARED_LIBS=1

recipes/squadgen/meta.yaml Outdated Show resolved Hide resolved
@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/squadgen) and found it was in an excellent condition.

@xylar xylar force-pushed the add-squadgen branch 3 times, most recently from 1427cca to 4a88fdc Compare May 12, 2024 16:01
xylar added 2 commits May 12, 2024 10:03
There is an import of `png.h` that turns out to not be used.
I have patched to remove this and SQuadGen now builds and runs
without requiring `libpng`.
@xylar
Copy link
Contributor Author

xylar commented May 12, 2024

@xhochy, thanks again for your help.

I finally solved the mystery. squadgen was including png.h but then not actually using it for anything (so I have patched to remove the unneeded include). Instead, it builds LodePNG internally and uses that. I have added the license for this as well.

@xylar
Copy link
Contributor Author

xylar commented May 12, 2024

@xhochy, the tests are now passing and there is no longer any overdependence. Would you be able to give this another look? Thank you!

@ocefpaf ocefpaf merged commit 1e9e903 into conda-forge:main May 13, 2024
5 checks passed
@ocefpaf
Copy link
Member

ocefpaf commented May 13, 2024

Thanks @xhochy for the review and @xylar for the package!

@xylar xylar deleted the add-squadgen branch May 14, 2024 01:24
@xylar
Copy link
Contributor Author

xylar commented May 14, 2024

Thanks so much @ocefpaf and @xhochy!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

3 participants