New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add recipe for squadgen #26335
Add recipe for squadgen #26335
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipes/squadgen:
Documentation on acceptable licenses can be found here. |
Note: this library includes the source for the legacy NetCDF C++ library, but it doesn't create a library of its own, just an executable. The license file has been included. |
@conda-forge/help-c-cpp, ready for review! |
@ocefpaf, another one that you might be willing to have a look at? Also, if you understand what I've done that is causing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe try BUILD_SHARED_LIBS=1
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
1427cca
to
4a88fdc
Compare
There is an import of `png.h` that turns out to not be used. I have patched to remove this and SQuadGen now builds and runs without requiring `libpng`.
@xhochy, the tests are now passing and there is no longer any overdependence. Would you be able to give this another look? Thank you! |
Checklist
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details).