Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add recipe for gen_domain tools from CIME #26334

Merged
merged 1 commit into from May 11, 2024

Conversation

xylar
Copy link
Contributor

@xylar xylar commented May 11, 2024

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/gen_domain) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/gen_domain:

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/gen_domain) and found it was in an excellent condition.

@xylar
Copy link
Contributor Author

xylar commented May 11, 2024

@conda-forge/staged-recipes, ready for review!

Copy link

To help direct your pull request to the best reviewers, please mention a topic-specifc team if your recipe matches any of the following: conda-forge/help-c-cpp, conda-forge/help-cdts, conda-forge/help-go, conda-forge/help-java, conda-forge/help-julia, conda-forge/help-nodejs, conda-forge/help-perl, conda-forge/help-python, conda-forge/help-python-c, conda-forge/help-r, conda-forge/help-ruby,or conda-forge/help-rust. Thanks!

@xylar
Copy link
Contributor Author

xylar commented May 11, 2024

@ocefpaf, would you have time to give this a quick look?

@ocefpaf ocefpaf merged commit 994602f into conda-forge:main May 11, 2024
5 checks passed
@xylar xylar deleted the add-gen_domain branch May 11, 2024 20:34
@xylar
Copy link
Contributor Author

xylar commented May 11, 2024

Thank you, @ocefpaf!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

2 participants