Added qh3 as a package #25193

thewchan · 2024-01-31T18:09:21Z

Checklist

conda-forge-webservices · 2024-01-31T18:09:44Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/qh3) and found it was in an excellent condition.

thewchan · 2024-01-31T19:42:48Z

@conda-forge/help-c-cpp @help-python-c It seems the ls-qpack is included in vendor directory in the source but somehow it's still complaining it can't find the header file? Tried adding the conda pylsqpack to no avail...

xhochy · 2024-02-04T09:44:17Z

recipes/qh3/meta.yaml

+    - {{ compiler('c') }}
+
+    # Adding this here as otherwise it relies on vendor lsqpack
+    - pylsqpack


This should be in host

let me try that

The compiler needs to stay in build.

got it I'll move it back

According to https://conda-metadata-app.streamlit.app/?q=conda-forge%2Flinux-64%2Fpylsqpack-0.3.18-py39hf860d4a_0.conda the package doesn't contain the file in question.

@xhochy does this mean the C library would need to be brought onto conda first?

Yes, we will need that first.

@xhochy, I've never worked on a pure C library for Conda before, is here a good example recipe you think I can reference?

Depends on what the build tool is. Is it using autotools?

I checked upstream, seems like CMake?

thewchan · 2024-02-05T18:38:46Z

@xhochy no dice still

  src/qh3/_vendor/pylsqpack/binding.c:4:10: fatal error: lsqpack.h: No such file or directory
      4 | #include "lsqpack.h"

thewchan · 2024-05-10T21:29:10Z

Hi @xhochy I'm pivoting back to this now, it's asking for libclang and I've added it to the build env, but somehow it's saying it still can't find it?

xhochy · 2024-05-11T11:03:51Z

recipes/qh3/conda_build_config.yaml

@@ -0,0 +1,2 @@
+c_stdlib_version:       # [osx and x86]
+  - '10.12'             # [osx and x86]


Suggested change

- '10.12' # [osx and x86]

- '10.13' # [osx and x86]

10.13 is now the new default/minimum

xhochy · 2024-05-11T11:05:31Z

recipes/qh3/meta.yaml

+    - {{ compiler('c') }}
+    - {{ compiler('rust') }}
+    - cmake
+    - libclang  # [linux]


Suggested change

- libclang # [linux]

This is something on PyPI only to reduce the size of binary artifacts (mostly?). In all recipes I have seen it, I just patched it out as a requirement.

I'll try Clang instead then

Or maybe I need to use Clang as the C compiler and not gcc?

@xhochy It seems that it's during the rust/cargo build phase it needs libclang, but not sure why it's not detecting it

thewchan · 2024-05-11T14:52:39Z

@xhochy New OSX errors

/Applications/Xcode_14.2.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.13.sdk/usr/include/CommonCrypto/CommonRandom.h:35:9: error: unknown type name 'CCCryptorStatus'

/Users/runner/Miniforge3/conda-bld/qh3_1715437872253/_build_env/.cargo/registry/src/index.crates.io-6f17d22bba15001f/aws-lc-sys-0.15.0/aws-lc/crypto/fipsmodule/rand/urandom.c:382:42: error: use of undeclared identifier 'kCCSuccess'

Also linux build still not working, same issue, can't find libclang. I might try switching from gcc to clang

xhochy · 2024-05-11T15:02:57Z

recipes/qh3/meta.yaml

+  host:
+    - python
+    - maturin >=1.2,<2.0
+    - pip


Suggested change

- pip

- pip

- clangdev

This is probably what you need

got it, let me try

xhochy · 2024-05-11T15:04:21Z

@xhochy New OSX errors


/Applications/Xcode_14.2.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.13.sdk/usr/include/CommonCrypto/CommonRandom.h:35:9: error: unknown type name 'CCCryptorStatus'



/Users/runner/Miniforge3/conda-bld/qh3_1715437872253/_build_env/.cargo/registry/src/index.crates.io-6f17d22bba15001f/aws-lc-sys-0.15.0/aws-lc/crypto/fipsmodule/rand/urandom.c:382:42: error: use of undeclared identifier 'kCCSuccess'

Also linux build still not working, same issue, can't find libclang. I might try switching from gcc to clang

I think you need openssl in host and set OPENSSL_DIR=$PREFIX

thewchan · 2024-05-11T15:15:15Z

@xhochy maybe it's confused now because there is both gcc and clang? Or is it asking for a c++ compiler

warning: aws-lc-sys@0.15.0: Compiler version doesn't include clang or GCC: "/home/conda/staged-recipes/build_artifacts/qh3_1715440102416/_build_env/bin/x86_64-conda-linux-gnu-cc" "--version"
  warning: aws-lc-sys@0.15.0: Failed to run: "c++" "--version"

xhochy · 2024-05-11T15:16:30Z

Yes, it needs a C++ compiler

thewchan · 2024-05-11T15:28:17Z

@xhochy it still has trouble finding a compiler, I wonder if I need to specify or change some env variables for Clang?

 warning: aws-lc-sys@0.15.0: Compiler version doesn't include clang or GCC: "/home/conda/staged-recipes/build_artifacts/qh3_1715440942569/_build_env/bin/x86_64-conda-linux-gnu-cc" "--version"
  warning: aws-lc-sys@0.15.0: Compiler version doesn't include clang or GCC: "/home/conda/staged-recipes/build_artifacts/qh3_1715440942569/_build_env/bin/x86_64-conda-linux-gnu-c++" "--version"

  error: failed to run custom build command for `aws-lc-sys v0.15.0`

xhochy · 2024-05-11T15:30:19Z

No. This should be buildable with gcc. Switching to clang might even bring more hassle in this case.

thewchan · 2024-05-11T15:32:02Z

It really is this aws-lc-sys-0.15.0 rust package causing all the problems in both linux and osx, but seems to be for different reasons

xhochy · 2024-05-11T15:37:30Z

I read a bit through its code. It seems like adding cmake to build and setting AWS_LC_SYS_CMAKE_BUILDER=1 may lead to better errors.

thewchan · 2024-05-11T15:41:20Z

@xhochy I already have cmake in build but let me try that env var

thewchan · 2024-05-11T15:51:18Z

Here's the additional error messages: https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=932139&view=logs&j=6f142865-96c3-535c-b7ea-873d86b887bd&t=22b0682d-ab9e-55d7-9c79-49f3c3ba4823&l=1149

xhochy · 2024-05-11T17:06:17Z

You need make in build

xhochy · 2024-05-11T20:40:25Z

recipes/qh3/meta.yaml

+    - {{ compiler('c') }}
+    - {{ compiler('cxx') }}
+    - {{ compiler('rust') }}\
+    - clangdev


This should only be in host

xhochy · 2024-05-11T20:40:32Z

recipes/qh3/meta.yaml

+    - {{ stdlib('c') }}
+    - {{ compiler('c') }}
+    - {{ compiler('cxx') }}
+    - {{ compiler('rust') }}\


Suggested change

- {{ compiler('rust') }}\

- {{ compiler('rust') }}

thewchan · 2024-05-13T15:07:08Z

@xhochy Thanks so much! Linux build is fixed. Now trying to figure out the OSX build, I found this possible related situation but not sure if it is addressable here: openssl/openssl#16458

Added qh3 as a package

d7fcf6f

thewchan added 2 commits January 31, 2024 13:20

Add pylsqpack to host

7f6f02c

Put pylsqpack in build instead

eefd751

github-actions bot added c-cpp review-requested labels Jan 31, 2024

xhochy reviewed Feb 4, 2024

View reviewed changes

Move C compiler and pylsqpack to host

4cf3838

thewchan closed this Feb 5, 2024

thewchan reopened this Feb 7, 2024

Move C compiler back to build

046a42d

carterbox removed the review-requested label Apr 24, 2024

github-actions bot added the Awaiting author contribution label Apr 24, 2024

thewchan added 3 commits May 10, 2024 16:07

Revamp recipe with >1.0.0 version

4a09d3e

Add cmake to build

931ecd9

libclang to build

d821452

Add osx rust support and nasm to win build

2c2d153

xhochy reviewed May 11, 2024

View reviewed changes

Bump cstdlib for osx and use clang instead of libclang

e47773f

xhochy reviewed May 11, 2024

View reviewed changes

Use clangdev instead

9c4a4f4

Add openssl to host for osx, add c++ compiler for everyone

f65dea4

AWS_LC_SYS_CMAKE_BUILDER=1

a1c9de4

make to build

1220724

xhochy requested changes May 11, 2024

View reviewed changes

Move clangdev to host

8d4f10c

Merge branch 'main' into qh3

88790c3

		@@ -0,0 +1,2 @@
		c_stdlib_version: # [osx and x86]
		- '10.12' # [osx and x86]

Added qh3 as a package #25193

Are you sure you want to change the base?

Added qh3 as a package #25193

Conversation

thewchan commented Jan 31, 2024

conda-forge-webservices bot commented Jan 31, 2024

thewchan commented Jan 31, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

thewchan commented Feb 5, 2024

thewchan commented May 10, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

thewchan commented May 11, 2024 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

xhochy commented May 11, 2024

thewchan commented May 11, 2024

xhochy commented May 11, 2024

thewchan commented May 11, 2024

xhochy commented May 11, 2024

thewchan commented May 11, 2024

xhochy commented May 11, 2024

thewchan commented May 11, 2024

thewchan commented May 11, 2024

xhochy commented May 11, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

thewchan commented May 13, 2024

thewchan commented May 11, 2024 •

edited