add RISE and ipytree #86
Conversation
rabernat
requested review from
jhamman,
scottyhq and
TomAugspurger
as code owners
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
Pinging @scottyhq, @jhamman, @TomAugspurger for a review of this. I don't understand the system well enough to know if I'm doing this right. |
|
Just noticing which repository this issue / PR is in. My initial reaction is that these packages would be more appropriate for whatever Is the primary motivation for putting it here, rather than in say https://github.com/pangeo-data/pangeo-docker-images/blob/master/pangeo-notebook/environment.yml, just wanting to have it in many different environments? |
|
I tried to explain the justification in #85. The thinking is that these packages are jupyter-related (not python related), and all of the jupyter-related machinery seems to live here. |
|
Gotcha. It's a judgement call so IMO this could go either way. How about we just merge it here and remove if it causes any dependency issues in the future? Let's give @scottyhq a few hours to respond and go ahead if we don't hear back. |
|
Agreed there is no clear cut decision making on these things, but the initial thinking of this repository was that it should have strictly required packages for pangeo jupyterhub and binderhubs. i've never used rise or ipytree... are they required together? If we want to ensure that RISE slideshow capability is always in every environment (pangeo-notebook, ml-notebook, etc.) it should go here. If it's just another ipywidget (ipytree?) that should probably go into a specific environment.
For consistency I'd recommend pinning, and updating the bot to bump versions when released. |
| @@ -5,7 +5,7 @@ package: | |||
| version: {{ version }} | |||
|
|
|||
| build: | |||
| number: 0 | |||
| number: 1 | |||
There was a problem hiding this comment.
unfortunately i don't think the bot knows how to change build numbers, so if you do want to add these, it's probably easiest to put this back to 0 and use a new date for the version (2021.09.09)
| @@ -17,6 +17,8 @@ requirements: | |||
| - jupyterhub-singleuser =1.4.2 | |||
| - jupyterlab =3.1.10 | |||
| - nbgitpuller =1.0.2 | |||
| - rise | |||
There was a problem hiding this comment.
i would suggest an explicit pin here for consistency with the other packages
|
closed in favor of pangeo-data/pangeo-docker-images#256 |
closes #85
Checklist
0(if the version changed)conda-smithy(Use the phrase@conda-forge-admin, please rerenderin a comment in this PR for automated rerendering)I did not pin versions. I don't know whether that would be the right choice.
I also wonder whether https://github.com/pangeo-bot/dispatcher/blob/main/.github/workflows/watch-pangeo-notebook-feedstock.yml needs to be updated to include RISE and ipytree, or whether we can just let them get resolved at build time. Would appreciate advice on this.