Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Result counter and timer don't update when map gets populated on Chrome #90

Open
KasperZutterman opened this issue Jun 29, 2021 · 3 comments

Comments

@KasperZutterman
Copy link
Contributor

KasperZutterman commented Jun 29, 2021

While the query is running the counter and clock are updating, but when the map is shown these fields freeze. Only when I press Stop Execution it gets updated.

Sample Query

image

This problem occurs on Google Chrome, on Firefox this isn't an issue.


Bounty

A bounty has been placed on this issue by:

Comunica Association
€136

Click here to learn more if you're interested in claiming this bounty by resolving this issue.

@rubensworks
Copy link
Member

For reference, this is probably because the code doesn't allow the render loop to take place.

Could by fixed by either making the map logic faster, letting it run in a separate worker (not sure if that would work), or only adding points to the map every X ticks.

@rubensworks rubensworks added the bug Something isn't working label Jun 29, 2021
@rubensworks rubensworks added this to To Do (prio:medium) in Maintenance via automation Jun 29, 2021
@rubensworks rubensworks added this to To do in Students Jun 29, 2021
@pietercolpaert
Copy link
Member

Indeed: it seems that now also the map will recalculate how it should be centered on each point that gets added, which requires also to check which tiles need to be downloaded on which zoom level. Probably buffering could be of help here?

@rubensworks
Copy link
Member

A bounty has been placed on this issue via the Comunica Association (see original post).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working comunica-association-bounty
Projects
Status: To Do (prio:medium)
Students
  
To do
Maintenance
  
To Do (prio:medium)
Development

No branches or pull requests

3 participants