Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bound check parsed literals #1265

Open
jitsedesmet opened this issue Sep 13, 2023 · 0 comments
Open

Bound check parsed literals #1265

jitsedesmet opened this issue Sep 13, 2023 · 0 comments

Comments

@jitsedesmet
Copy link
Member

In the expression-evaluator, the TermTransformer allows transforming literals to the EE internal types. Sometimes corners are cut and the value of the parsed literals are not thoroughly checked. For example, when parsing decimals, we don't check if the provided number actually fits the bound of the literal type.

For example, parsing "{a very big number}"^^short will just work, even though the number does not fit the bounds.

We should also think about how to handle these kinds of invalid values. Are they Non-lexical (I think so)? Or do we throw a warning? Or do nothing to avoid (minimal) overhead?

This is originally mentioned in an issue of the sparqlee repo: comunica/sparqlee#45.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants