Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

peer review validation #437

Open
alee opened this issue Apr 10, 2019 · 2 comments
Open

peer review validation #437

alee opened this issue Apr 10, 2019 · 2 comments
Assignees
@chrstngyn
Labels
enhancement feature high priority

Comments

@alee
Copy link
Member

alee commented Apr 10, 2019

peer review requests shouldn't go through if there is no code / documentation to review
@alee
Copy link
Member Author

alee commented Jul 12, 2019

@MarcoAJanssen suggests that we also run full publish validation on the model to ensure it has all the metadata fields required for publishing as well

@chrstngyn chrstngyn self-assigned this Aug 5, 2019
@alee alee mentioned this issue Aug 14, 2019
Closed
chrstngyn pushed a commit to chrstngyn/comses.net that referenced this issue Aug 30, 2019
added peer review form verification
6bbef28 
codebase should have all necessary metadata fields (oss license,
uploaded documentation, uploaded code, contributors properly added)
wrote tests to test metadata completeness
* test fails when programming language is added, should return false - instead returns true, indicating all metadata fields are complete.

see: comses#437
chrstngyn pushed a commit that referenced this issue Aug 30, 2019
added peer review form verification
73957da 
    codebase should have all necessary metadata fields (oss license,
    uploaded documentation, uploaded code, contributors properly added)
    wrote tests to test metadata completeness
    * test fails when programming language is added, should return false - instead returns true, indicating all metadata fields are complete.

    see: #437
@alee
Copy link
Member Author

alee commented Sep 26, 2019 •
edited

This is almost working, but not quite. When I request a peer review for a model that isn't publish()-able, it returns without requesting the peer review, but I don't see any of the appropriate / relevant error messages. Instead, I only see the relevant validation error messages if I request peer review again, e.g.:

peer-review-errors

hwelsters pushed a commit to hwelsters/comses.net that referenced this issue May 10, 2023
added peer review form verification
c261ad9 
    codebase should have all necessary metadata fields (oss license,
    uploaded documentation, uploaded code, contributors properly added)
    wrote tests to test metadata completeness
    * test fails when programming language is added, should return false - instead returns true, indicating all metadata fields are complete.

    see: comses#437
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chrstngyn chrstngyn

Labels
enhancement feature high priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alee @chrstngyn