Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No way to respect PHP version requirements when only-best-candidates set to true #687

Open
winiarekk opened this issue Dec 30, 2021 · 0 comments

Comments

@winiarekk
Copy link

Is your feature request related to a problem? Please describe.
It seems that there is no way to configure satis to build repository working for given PHP version if only-best-candidates is set to true.

For example if we have an environment running PHP 7.3 and we want to use "friendsofphp/php-cs-fixer": "2.18.1", which is compatible with php: ^5.6 || ^7.0 || ^8.0, setting the flag only-best-candidates to true will cause building a repo with some of the dependencies that are compatible only with PHP 8 (for example "symfony/string": "v6.0.2").

Then, if we try to use our satis repository in the application, composer will fail with the message:
image

I tried to set desired environment in satis.json file require section, but then building fails with the message:
image

Describe the solution you'd like
There should be possibility to define desired platform requirement.

Describe alternatives you've considered
Alternatively, setting the flag only-best-candidates to true should result in including best dependency candidate for each PHP version compatible with packages defined in satis.json

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants