Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Branch alias is not detected by satis #646

Open
Radon8472 opened this issue Apr 7, 2021 · 4 comments
Open

Branch alias is not detected by satis #646

Radon8472 opened this issue Apr 7, 2021 · 4 comments
Labels

Comments

@Radon8472
Copy link

Radon8472 commented Apr 7, 2021

Describe the bug
I have a repo in satis, that uses branch-alias and the alias branch-versions are not listed in the satis index.html and package.json - files

To Reproduce

  • Create a repo that uses branch-alias e.g. like this:
    "extra": {
      "branch-alias": {
        "dev-develop": "1.0.x-dev"
      }
    }
  • include this repo in your satis-config file
  • run bin\satis.bat build

Outcome
in the index.html it shows

Releases: dev-master, dev-develop
for this repo.
(json-file for this repo in satis storage shows only config releases "dev-master, dev-develop")

Expected behavior
Satis should show / list the branch-alias versions too.

e.g. composer show on the included repo shows:

versions : 1.0.x-dev, * dev-develop

so satis should list version 1.0.x-dev from the branch-alias in its "releases"-section in index.html and in the json-file for this package.

Additional context
I am not sure if this is relevant for this problem, but the included repo is hosted on gitlab.

@Radon8472 Radon8472 added the bug label Apr 7, 2021
@alcohol
Copy link
Member

alcohol commented Apr 7, 2021

Is your gitlab repository public? Do you have a complete reproducible scenario (repository + satis.json)?

@Radon8472
Copy link
Author

Radon8472 commented Apr 7, 2021

Unfortunally the repo is a companies project so I cant make it public, but I could post my satis.json and yust replace the projects-name with dummy values.

{
  "name": "mycompany/projectname",
  "homepage": "https://my-companys-project-page",
  "repositories": [
    {
      "type": "gitlab",
      "url": "https://gitlab.com/mycompany/mygroup/myproject",
      "name": "mygroup/myproject"
    },
  ],
  "require-all": true,
  "providers": true
}

I excluded all other repos that are not affected by this bug.

@alcohol
Copy link
Member

alcohol commented Apr 7, 2021

Unfortunately I don't have the time to setup/create a reproducible scenario from scratch.

@Radon8472
Copy link
Author

You yust need a nearly empty project that contains a composer.json like this:

{
  "name": "demo/repo",
  "keywords": [],
  "version": "1.0.0",
  "authors": [
    {
    },
  ],
  "require": {
  },
  "extra": {
    "branch-alias": {
      "dev-develop": "1.0.x-dev"
    }
  }
}

And create a branch develop there. That should be all that you need to reproduce this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants