Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] replaced-by key #6934

Closed
greg0ire opened this issue Dec 21, 2017 · 3 comments
Closed

[Feature request] replaced-by key #6934

greg0ire opened this issue Dec 21, 2017 · 3 comments

Comments

@greg0ire
Copy link
Contributor

Some packages, like symfony/polyfill-mbstring do things only if an extension like ext-mbstring is missing. I think a configuration key that would act as the inverse of replaces could be useful in that kind of case.

@javiereguiluz
Copy link
Contributor

How would this work for packages like symfony/polyfill-php56 where the install rule is: "ignore this package if PHP version is PHP 5.6 or higher".

@greg0ire
Copy link
Contributor Author

greg0ire commented Dec 22, 2017

@javiereguiluz you're right, it should probably not be that simple. I think it could look like this:

    "name": "symfony/polyfill-php56",
    "replaced-by": {
        "php": ">=7.0"
    }

or

    "name": "symfony/polyfill-mbstring",
    "replaced-by": {
        "ext-mbstring": "*"
    }

@greg0ire greg0ire changed the title [Feature request]replaced-by key [Feature request] replaced-by key Dec 22, 2017
@Seldaek
Copy link
Member

Seldaek commented Apr 13, 2018

Closing as I don't think this is likely to happen. It's too complex for what it brings IMO, installing a bit of code that's not needed isn't the worst problem.

@Seldaek Seldaek closed this as completed Apr 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants