Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow for proper children slots/nesting #467

Open
johno opened this issue Jul 13, 2022 · 0 comments
Open

Allow for proper children slots/nesting #467

johno opened this issue Jul 13, 2022 · 0 comments
Assignees
@johno
Labels
Compilation Parsing and serialization Feature New feature or request HTML GUI

Comments

@johno
Copy link
Contributor

johno commented Jul 13, 2022 

<div>
  <H1>{headingText}</H1>
  <ButtonLink>{buttonText}</ButtonLink>
</div>
@johno johno added Feature New feature or request Compilation Parsing and serialization HTML GUI labels Jul 13, 2022
@johno johno self-assigned this Jul 13, 2022
@johno johno mentioned this issue Jul 14, 2022
Merged
johno added a commit that referenced this issue Jul 15, 2022
@johno
Extract canvas prop instantiation to its own hook
38b95c3 
Now that we have components and slots, there's a bit more complexity
to how we handle things like canvas selection and rendering. So, this
breaks this logic out into a standalone hook to make things more clear
around what's happening.

Refactor to prep for #487
Related to #467
johno added a commit that referenced this issue Jul 15, 2022
@johno
Extract canvas prop instantiation to its own hook
e2bd4fb 
Now that we have components and slots, there's a bit more complexity
to how we handle things like canvas selection and rendering. So, this
breaks this logic out into a standalone hook to make things more clear
around what's happening.

Refactor to prep for #487
Related to #467
@johno johno mentioned this issue Jul 15, 2022
Merged
johno added a commit that referenced this issue Jul 15, 2022
@johno
Clean up html renderer and editors
b6d1c2f 
Prep for #481 and #467
@johno johno mentioned this issue Jul 15, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@johno johno

Labels
Compilation Parsing and serialization Feature New feature or request HTML GUI
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@johno