Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dependencies are outdated #6

Open
2 of 4 tasks
sbryngelson opened this issue Jan 15, 2024 · 1 comment
Open
2 of 4 tasks

Dependencies are outdated #6

sbryngelson opened this issue Jan 15, 2024 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@sbryngelson
Copy link
Member

sbryngelson commented Jan 15, 2024 •
edited by suzm10

This codebase carries several very out of date dependencies. This makes it quite challenging to build and likely affects performance. Resolving this issue would substitute more up-to-date or modern/difference packages for such things. Below are some example packages.

  • Intel MKL (current version very very old)
  • PETSc (current version very very old)
  • GMRES solver (currently a hardcoded file?)
  • Build system relying upon makedepf90
@sbryngelson sbryngelson added enhancement New feature or request good first issue Good for newcomers labels Jan 15, 2024
@suzm10
Copy link
Contributor

suzm10 commented May 24, 2024

There is no hardcoded GMRES file. It's using a custom PETSc matrix shell operation in ModVelSolver.F90 and ModNoSlip.F90.

@suzm10 suzm10 linked a pull request May 28, 2024 that will close this issue
MKL/Lapack Update #31
Merged
10 tasks
@suzm10 suzm10 removed a link to a pull request May 28, 2024
MKL/Lapack Update #31
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sbryngelson @suzm10