Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

comment on public ARCFileReader constructor is confusing #14

Open
banshee opened this issue May 4, 2017 · 2 comments
Open

comment on public ARCFileReader constructor is confusing #14

banshee opened this issue May 4, 2017 · 2 comments

Comments

@banshee
Copy link

banshee commented May 4, 2017

On line 102 of commoncrawl/src/main/java/org/commoncrawl/util/shared/ARCFileReader.java, there's a comment that says the constructor is private (it's actually public), and refers to the "factory method above" even though it's the first method in the file.

  /** 
   * constructor is now private. use the factory method above to construct a reader 
   * @param source
   * @throws IOException
   */
  public ARCFileReader(final InputStream source)throws IOException {
    super(new CustomPushbackInputStream(new CountingInputStream(source),
        _blockSize), new Inflater(true), _blockSize);
    readARCHeader();
  }

@sebastian-nagel
Copy link
Contributor

Thanks, I'll have a look at it. But just for clarification: this library is used to access the Common Crawl data from 2012 or earlier. Recent data uses a different format (WARC instead of ARC).

@banshee
Copy link
Author

banshee commented May 5, 2017

Oh, that's a great reason to just close as won't-fix. I had just started poking around the code and I forgot that distinction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants