Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull request template #103

Open
pvanheus opened this issue Oct 7, 2020 · 1 comment
Open

Pull request template #103

pvanheus opened this issue Oct 7, 2020 · 1 comment

Comments

@pvanheus
Copy link
Contributor

pvanheus commented Oct 7, 2020

What should go into a PR template for this repository? I'd like to propose the following:

  • Radio button with options:
    This PR adds a new tool descriptor
    This PR updates a tool descriptor
    This PR does something else
  • Check box: "I have read the CONTRIBUTING.md" document
  • Check box: "I am making this work available under the terms of the Apache License 2.0 (as per the LICENSE file)"

And then as a stop-gap for testing, perhaps we can ask that the test in the tests/ folder be run by the contributor and the cwltool output of running the test is appended as a comment in the PR. I'm not sure exactly how to work this but more importantly, what do others think about this? It will at least ensure that contributed tools are working.

Then on the last check box proposed above, how does that relate to the public domain donations issue? And do / should tool contributors retain copyright to their tools?

Finally, what else is there to add to such a template?

@cwl-bot
Copy link

cwl-bot commented Oct 7, 2020

This issue has been mentioned on Common Workflow Language Discourse. There might be relevant details there:

https://cwl.discourse.group/t/moving-bio-cwl-tools-forward/213/2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants