Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for empty pages #336

Open
jasonlam0627 opened this issue Oct 30, 2022 · 7 comments
Open

Check for empty pages #336

jasonlam0627 opened this issue Oct 30, 2022 · 7 comments

Comments

@jasonlam0627
Copy link

user_guide/cwl/sphinx/init.py
user_guide/src/LICENSE.md
user_guide/pyproject.toml
user_guide/src/episodes.md is removed
user_guide/src/setup.md is removed

and the page user_guide/src/introduction/index.md is just direct to the file inside ~/introduction
maybe it can be rename to readme.md

@swzCuroverse
Copy link
Contributor

@jasonlam0627 can you give me a bit more context?

@swzCuroverse
Copy link
Contributor

I think these are placeholders. @kinow do you know which one of these are placeholders (and so need a ticket to create) and which can be safely removed?

@swzCuroverse
Copy link
Contributor

user_guide/src/episodes.md is removed
user_guide/src/setup.md is removed

Have been kept to ensure the old links still work -- I think it says that on the page.

@swzCuroverse
Copy link
Contributor

@kinow or @mr-c thoughts on this one?

@kinow
Copy link
Member

kinow commented Jan 4, 2023

I remember at first I left the pages while testing to make sure the links were not broken. Later I found out that it would be simpler to move content from sections and add redirects using Sphinx. Can't recall if there's any special reason for leaving these files behind.

If someone could test removing them and verifying if we already have something in Sphinx configuration to prevent 404's, or if we can add something there, then +1 to the removal of these empty/old pages.

@Mackenzie-OO7
Copy link
Contributor

@kinow I tested removing user_guide/pyproject.toml and moving the contents in user_guide/LICENSE.md to user_guide/src/LICENSE.md, then deleting user_guide/LICENSE.md and all the links still work.

@kinow
Copy link
Member

kinow commented Jan 19, 2023

@kinow I tested removing user_guide/pyproject.toml and moving the contents in user_guide/LICENSE.md to user_guide/src/LICENSE.md, then deleting user_guide/LICENSE.md and all the links still work.

Got it! I think pyproject.toml and LICENSE.md are supposed to stay in the root directory. LICENSE.md is used by GitHub and most devs will look for it at the root dir. Maybe we can just reference it in the site without moving it (assuming we need to). The toml file is for Python packaging, see

Although that could change in the future, see

So I think we should focus on the empty pages in the src directory only, for now 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants