Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename/alias dockerImageId to dockerImageName #922

Open
qwofford opened this issue Apr 12, 2021 · 1 comment
Open

rename/alias dockerImageId to dockerImageName #922

qwofford opened this issue Apr 12, 2021 · 1 comment
Milestone

Comments

@qwofford
Copy link

A Docker Image ID refers to the MD5 checksum of a complete docker image. If the CWL spec includes "dockerFile" and "dockerImageId" at the same time, this results in a logical conflict.

The dockerImageId is an Md5 which corresponds with a particular container manifest, ref: https://docs.docker.com/engine/reference/commandline/images/

So it's not possible to set a dockerImageId without first having built the dockerFile specified. It seems that introducing a dockerImageName and dockerImageTag to the CWL spec would solve this problem.

See the following discussion for related discussion:
https://cwl.discourse.group/t/dockerimageid-can-not-be-known-before-dockerfile-build/223

@mr-c mr-c added this to the cwlnext milestone Sep 11, 2021
@mr-c mr-c changed the title CWL dockerImageId usage inconsistent with Docker rename/alais dockerImageId to dockerImageName Dec 16, 2023
@mr-c mr-c changed the title rename/alais dockerImageId to dockerImageName rename/alias dockerImageId to dockerImageName Dec 16, 2023
@mr-c
Copy link
Member

mr-c commented Dec 16, 2023

To be clear here, in CWL dockerImageId is a name, not the container image checksum. I agree this is confusing and that a new alias for this concept should be added in CWL v1.3; a deprecation notice added; and removing dockerImageId in a future CWL version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants