Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a cwl-runner error code for validation failure #915

Open
mr-c opened this issue Nov 10, 2020 · 3 comments
Open

add a cwl-runner error code for validation failure #915

mr-c opened this issue Nov 10, 2020 · 3 comments
Milestone

Comments

@mr-c
Copy link
Member

mr-c commented Nov 10, 2020

https://github.com/common-workflow-language/cwl-v1.2/blob/main/cwl-runner.cwl#L56

@mr-c mr-c transferred this issue from common-workflow-language/cwl-v1.2 Nov 10, 2020
@mr-c mr-c added this to the cwlnext milestone Nov 10, 2020
@mr-c
Copy link
Member Author

mr-c commented Dec 21, 2020

Consider also adding https://github.com/IBMSpectrumComputing/cwlexec#exit-code-definition

Exit Code Description
0 The workflow is done
33 There is an unsupported feature in the workflow
130 User used Ctrl + C to interupt the workflow
250 The workflow input/output cannot be found
251 Fail to parse workflow
252 Fail to load workflow inputs
253 Fail to evaluate the expression in workflow
254 Fail to capture the workflow/step output after the workflow/step is done
255 System exception. For example, command arguments are wrong; the CWL workflow description file cannot be found; bsub/bwait command cannot be found

@tetron What do you think of these exit codes for the cwl-runner interface?

@tetron
Copy link
Member

tetron commented Dec 21, 2020

Sure, that seems like a good idea. We would want to adjust cwltool to emit them. Would "validation error" be code 251 in this scheme?

@mr-c
Copy link
Member Author

mr-c commented Dec 21, 2020

Would "validation error" be code 251 in this scheme?

Do you want to distinguish between bad YAML/JSON and other errors? If so then we need separate exit codes, otherwise that would all be 251, yep.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants