Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Telemetry is not emitted if dispatch fails for {:error, :unregistered_command} #475

Open
leggebroten opened this issue Feb 22, 2022 · 2 comments

Comments

@leggebroten
Copy link

If a Command is dispatched to a Router it's not been registered with, the dispatch fails with {:error, :unregistered_command} but a Telemetry span is not created.

Is this intended or should I create an issue and fix? Proposal would be a span with error status.
(It seems we should be invoking [:commanded, :application, :dispatch], set :error and perhaps attaching an event since it's logging in that case)

When Command is not registered with Router

{:error, :unregistered_command}

Normal dispatch

start_time = telemetry_start(telemetry_metadata)

@davydog187
Copy link
Contributor

@leggebroten this is not intended. Please fix if you have bandwidth :)

@leggebroten
Copy link
Author

@davydog187 I should be able to start next week

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants