Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

First apply than handle in Process managers #176

Open
aef opened this issue Jun 20, 2018 · 3 comments · May be fixed by #405
Open

First apply than handle in Process managers #176

aef opened this issue Jun 20, 2018 · 3 comments · May be fixed by #405
Labels
proposal

Comments

@aef
Copy link

aef commented Jun 20, 2018 •
edited

I have a question about the behavior of process managers in Commanded. For better exposure, I asked my question here. To me it seems that the current behavior might be a bug.
@aef aef changed the title First apply than handle in Process managers First apply than handle in Process managers Jun 20, 2018
@arfl
Copy link

arfl commented Jun 21, 2018

+1

@slashdotdash
Copy link
Member

Process manager state should be mutated, using the apply/2 callback function, before the domain event is processed by the handle/2 callback.

@jdewar
Copy link
Contributor

jdewar commented Dec 12, 2018

The current approach can be useful. If handle blows up, I may want the process manager to be restarted with the 'previous' state; applying first would would mean I have the 'next' state.

@Cantido Cantido linked a pull request Oct 11, 2020 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
proposal
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Process Managers: mutate state before handling event Cantido/commanded
4 participants
@slashdotdash @aef @arfl @jdewar