Application used in e2e tests appears to commit state in InitChain

[joshklop]

According to this issue, applications only commit their state when receiving a Commit request. It appears the test application in test/e2e/app commits its state when it receives a non-empty AppStateBytes via a call to state.Import.

Is this a bug?

P.S. what is the initial_height? The docs say it is the "height of the initial block", but it appears the test application uses 0 as the height of the genesis state.

[lasarojc]

Hi Joshklop
You may be right here, as InitChain will be called again if there is a failure, so the state shouldn't have been persisted.
I am converting this discussion to an issue while it is further analyzed.