Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to std::io::IsTerminal for v3 #144

Open
kurtlawrence opened this issue Jul 4, 2023 · 3 comments
Open

Switch to std::io::IsTerminal for v3 #144

kurtlawrence opened this issue Jul 4, 2023 · 3 comments
Labels
breaking Will need a major version bump

Comments

@kurtlawrence
Copy link
Collaborator

For the v3 release, switch to using std::io::IsTerminal.
@kurtlawrence kurtlawrence added the breaking Will need a major version bump label Jul 4, 2023
@juntyr
Copy link

juntyr commented Jul 4, 2023

+1 from me for removing the atty dependency

@Oakchris1955
Copy link
Contributor

I opened a PR (#149) which uses the built-in trait instead of the external crate. I hope it get approved by the maintainers

@hwittenborn
Copy link
Member

Thanks for the PR @Oakchris1955! I'll get that merged in once the v3 branch gets created - there's a few other PRs that need to get merged, and then I'll get that looked at.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking Will need a major version bump
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@kurtlawrence @juntyr @hwittenborn @Oakchris1955