-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The source packages of collectd-5.9.2 aren't generated by the formal procedure #3293
Comments
I can add that the file hasn't been uploaded to collectd.org either (the spec file depends on that) |
I've confirmed that it can be fixed locally by adding the annotation:
|
Now I'm wondering how were collectd-5.9.2 packages generated? In general, source packages for Autotoolized software should be generated by:
but they doesn't seem use it, because:
|
collectd-5.9.2.tar.bz2 is not a bzip2 file, but instead it seems to be a .xz file which has an .tar file inside. (so instead of a tar bzip2 archive, we got a tar archive inside an xz archive.) This leads to errors in real life usage:
And like mentioned above, the file contains several megabytes of autom4te.cache etc. |
And another shortcoming since the 5.9.x source release tar files, the (generated) file src/liboconfig/parser.c is missing, forcing a local bison installation (or host-bison in case of cross-compile, as detected by the buildroot autobuilds, see [1] for details)..., is this a 'bug' of the tarball or intentional? [1] http://lists.busybox.net/pipermail/buildroot/2019-October/261555.html |
All these issues are bugs, because release process done by another person than before. |
this is starting to get really weird @mrunge your email is bouncing back... |
Oh oh. sigh. Bear with me, I have been a few days cut off the net. I'm sorry this happened, it has not been intentional. Let's see what can be done to fix this here. |
So, I've updated the tarball on the release page here on github. |
Thanks for the work 😃 |
There are currently different files .tar.bz2 to be downloaded at different locations leading to uncertainly on automated downloads: https://collectd.org/files/collectd-5.9.2.tar.bz2 https://github.com/collectd/collectd/releases/download/collectd-5.9.2/collectd-5.9.2.tar.bz2
Please upload the correct file also to to collectd.org (if it is indeed the correct file. I haven't yet tested it as I stumbled at the download step.) |
I don't have access to collectd.org, and tbh, I am astonished, that collectd-5.9.2 shows up there.
|
Just as a pointer, the release process is documented https://collectd.org/wiki/index.php/Release_process |
Maybe the process description is not quite complete, or it was not followed right: https://github.com/collectd/collectd/blob/collectd-5.9/version-gen.sh Example:
It might be sensible to first fix things in the 5.9 branch and then release a new 5.9.3 that would contain the proper stuff and proper versioning. Then there wouldn't be competing source version floating around in the various foss source mirrors. E.g fossies.org has 5.9.2 now the first version of the 5.9.2 tar.xz (the first bz2 file properly identified?) that still claims to be 5.8.1 in the version-gen.sh (Less than funny, but source jump from 5.9.0 to 5.9.2 decreases the version to 5.8.1... Ps. not sure if the advice is still relevant/current, but there is advice about building the bzip2 distribution archive in collectd/contrib/redhat/collectd.spec Line 18 in e1325d5
(that might also explain why the bz2 file still contains slightly different stuff in 5.9.2 than in 5.9.0). |
@mrunge thanks Matthias missed this rather long trial... BTW I came across the same issue with version-gen.sh file in the pkg-debian build as well. As per @ashie the fix was to put in annotated tag: git tag -a collectd-5.9.2-1 -m "Add 5.9.2 tag" The version-gen.sh (DEFAULT_VERSION) is really a red herring as process always uses "git describe" result for version info. I have just verified on my test build which is now generating: collectd-5.9.2.1.tar.bz2 Final point you have to explictly push tag... git push origin collectd-5.9.2-1 (which you likely know, but I didn't and keep wondering where they where going ;-) ) |
Signed tag works too |
Expected behavior
version-gen.sh script should generate "5.9.2" on collectd-5.9.2 tag.
Actual behavior
version-gen.sh script generates "5.9.1.7.gdfb9dd0 on collectd-5.9.2 tag.
Steps to reproduce
Cause of the issue
collectd-5.9.2 tag isn't annotated.
The text was updated successfully, but these errors were encountered: