Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude replies with negative feedback when notifying users #265

Open
MrOrz opened this issue Jun 16, 2021 · 0 comments
Open

Exclude replies with negative feedback when notifying users #265

MrOrz opened this issue Jun 16, 2021 · 0 comments
Labels
enhancement good first issue Picked for newcomers

Comments

@MrOrz
Copy link
Member

MrOrz commented Jun 16, 2021

Discussion: https://g0v.hackmd.io/giYWfM8yRkKghtPOG1EBig#%E4%BA%82%E5%9B%9E%E8%88%87%E9%80%9A%E7%9F%A5

We should not notify LINE user of replies with negative feedbacks.

getArticlesInBatch() in src/scripts/lib.js should only yield articles when there are new replies having positive or zero feedbacks (positive - negative score >= 0).
@MrOrz MrOrz added enhancement good first issue Picked for newcomers labels Jun 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement good first issue Picked for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@MrOrz