Fix issue 157 replyToken empty #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrOrz
reviewed
Feb 29, 2020
src/index.js
Outdated
| setTimeout(function() { | ||
| if (isReplied) return; | ||
|
|
||
| let timerId = setTimeout(function() { |
There was a problem hiding this comment.
We can declare const here because no one is going to mutate timerId.
nonumpa
force-pushed
the
issue/157-empty-replytoken
branch
from
fbb20e1
to
4c92aad
Compare
|
It is confirmed to be working on staging environment. Now deploying it to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clear timeout function when
returnor when message replied.Fixes bugs :
1.Unfollow event which doesn't have replyToken causes
[LINE Client] 400: The request body has 1 error(s).2.Follow event sends an extra message
不好意思！系統可能在忙線中，無法及時處理您傳的訊息。請稍等幾分鐘再試試看唷。to user after timeout.3.Previous button pressed(postback message) sends message
不好意思！系統可能在忙線中，無法及時處理您傳的訊息。請稍等幾分鐘再試試看唷。to user after timeout.