Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix invalid replyToken, add timeout mechanism #156

Merged
merged 3 commits into from Feb 26, 2020
Merged

Fix invalid replyToken, add timeout mechanism #156

merged 3 commits into from Feb 26, 2020

Conversation

nonumpa
Copy link
Member

@nonumpa nonumpa commented Feb 26, 2020 •
edited

Fixes #154

@coveralls
Copy link

coveralls commented Feb 26, 2020 •
edited

Pull Request Test Coverage Report for Build 623

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 96.25%
Totals Coverage Status
Change from base Build 614: 0.0%
Covered Lines: 219
Relevant Lines: 225
💛 - Coveralls

MrOrz
MrOrz requested changes Feb 26, 2020
View reviewed changes
Copy link
Member

@MrOrz MrOrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much!

Let's add console and translation and we are good to go!

src/index.js Show resolved Hide resolved
src/index.js Show resolved Hide resolved
@MrOrz MrOrz merged commit 6c4d537 into dev Feb 26, 2020
@MrOrz MrOrz deleted the issue/154-invalid-replytoken branch February 26, 2020 15:56
@MrOrz
Copy link
Member

MrOrz commented Feb 27, 2020

It's working on staging! I have added a console.log to show when replies are aborted.
Let's push it to production and see if it resolves https://rollbar.com/mrorz/rumors-line-bot/items/56/

螢幕快照 2020-02-27 上午11 50 03

@nonumpa nonumpa mentioned this pull request Feb 28, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrOrz MrOrz MrOrz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[LINE Client] 400: Invalid reply token.
3 participants
@nonumpa @coveralls @MrOrz