Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

URL resolve failure will cause UI to poll hyperlinks forever #152

Open
MrOrz opened this issue Feb 29, 2020 · 1 comment
Open

URL resolve failure will cause UI to poll hyperlinks forever #152

MrOrz opened this issue Feb 29, 2020 · 1 comment
Labels
Good first issue

Comments

@MrOrz
Copy link
Member

MrOrz commented Feb 29, 2020

In #147 we modified the reply sending logic so that it first sets hyperlinks to a temp value and rely on promises to fill in hyperlinks after loading finishes.

However, the procedure may fail and cause forever polling scenario like this:
https://cofacts.g0v.tw/reply/H4TBinABWiTSPYAZPHxn

Needs further discussion on

  • How many replies are affected
  • How this can be mitigated
@MrOrz
Copy link
Member Author

MrOrz commented Mar 11, 2020 •
edited

Impact: many replies
Mitigation: handle scraping error and fill in empty arrays to hyperinks

As for unit tests, we can mock scrapUrl to make it throw exceptions. It should insert empty arrays in the end.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Good first issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@MrOrz