Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding context to Geocoder interface #72

Open
friend0 opened this issue Dec 21, 2021 · 1 comment
Open

Adding context to Geocoder interface #72

friend0 opened this issue Dec 21, 2021 · 1 comment

Comments

@friend0
Copy link

friend0 commented Dec 21, 2021

Would you accpet a PR, or consider modifying this module such that users could pass a context to the Geocoder interface?
This addition would make this module much more powerful in production, since web servers would be able to pass the top level context for things like tracing and etc. The new interface would not be backwards compatible, but would be trivial for users to update, i.e. provide context.TODO to their calls as you've done

@codingsince1985
Copy link
Owner

hi @friend0, sounds like a great PR idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants