Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The effect's list needs a scroll so more effects can be added (w/ suggestion code) #58

Open
LuisMQuinones opened this issue May 15, 2018 · 6 comments
Assignees

Comments

@LuisMQuinones
Copy link

We can't add any new effects to the Effect effectsArray, or better; anymore toggles to RadioButton activeEffect, because the additional toggles are rendered off screen.

I looked for ways to wrap the activeEffect into one of the scroll controllers like ListBox or ScrollableList.
I think we may need to drop RadioButton activeEffect in favor of a ScrollableList with no visible bar.

I wrote some short code to test it out:

screen shot 2018-05-15 at 7 01 37 pm

cp5 = new ControlP5(this);
scroll = cp5.addScrollableList("scroll")
     .setType(ScrollableList.LIST)       
      .setBarHeight(0)
      .setSize(150,150)
      .setItemHeight(20)
      .setBarVisible(false)
      .setPosition(width/2-75,height/2-75) ;
void scroll(int i){
     //println(i, cp5.get(ScrollableList.class, "scroll").getItem(i));
     Effect effect = (Effect)cp5.get(ScrollableList.class, "scroll").getItem(i).get("value");
     println("id",effect.val,"name",effect.name,"was chosen");
   }

I think it looks like the original implementation with an added scrollbar.
@codingjoe I'll love to hear what you think.

@LuisMQuinones LuisMQuinones changed the title The effect's list needs a scroll so more effects can be added The effect's list needs a scroll so more effects can be added (w/ suggestion code) May 15, 2018
@codingjoe
Copy link
Owner

@LuisMQuinones thanks for the research good work. I agree this looks like the best solution. We should probably define a frame size, that works on most screens. I would not keep the current one, I would like the bottom button to be only half in the viewport by default. That way it's visually identifiable that the frame can scrolled.

@codingjoe
Copy link
Owner

codingjoe commented May 22, 2018

That being said, I can't wait for your PR! Whats the new effect you are working on?

@LuisMQuinones
Copy link
Author

I plan on making quite a few effects; if you don't mind.

The one that I plan on PR first is called LightBugs_Effect. It "simulates" bugs crawling across the screen. One set of beat dictates the spawn rate of the bugs, and another set of beats dictates the size of the bug. The bugs get bigger as beat detects, and they get smaller as time passes.

I have to keep tweaking it a bit, and I need to add the customization aspect to the effect. I don't have a projector to test out the effect, so I'm also waiting on that. I created a tool to help me imagine the effects though. I posted screenshots of the tool as issue: #59.

lightbugsscreenshot

@codingjoe
Copy link
Owner

That's so cool. Where do you live? Maybe I can hook you up with a projector...

@LuisMQuinones
Copy link
Author

Thank you so much! I was actually nervous for my first contributions.

I live in MA, USA, so I don't think that is convenient. I really appreciate the amazingly kind gesture!

Do you know how well a cheap sub $100 Amazon projector works? At least development purposes? I found a few with 2000 Lumen and a 1000:1 Contrast.

@lh84
Copy link

lh84 commented Feb 5, 2022

I plan on making quite a few effects; if you don't mind.

The one that I plan on PR first is called LightBugs_Effect. It "simulates" bugs crawling across the screen. One set of beat dictates the spawn rate of the bugs, and another set of beats dictates the size of the bug. The bugs get bigger as beat detects, and they get smaller as time passes.

I have to keep tweaking it a bit, and I need to add the customization aspect to the effect. I don't have a projector to test out the effect, so I'm also waiting on that. I created a tool to help me imagine the effects though. I posted screenshots of the tool as issue: #59.

lightbugsscreenshot

Hi do you want to share your bugs effect with us?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants