Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Searches persist in Members and Administrators Popup #637

Open
ksraj123 opened this issue Sep 30, 2020 · 5 comments · May be fixed by #643
Open

[BUG] Searches persist in Members and Administrators Popup #637

ksraj123 opened this issue Sep 30, 2020 · 5 comments · May be fixed by #643
Labels
bug Something isn't working good first issue Good for newcomers HACKTOBERFEST

Comments

@ksraj123
Copy link
Contributor

Describe the bug
Search results in the members and administrators modals persist on closing on opening the modals again. There is no way to clear the search result other than searching for blank or switching to a different page and stitching back, both of these are not intuitive and lead to bad user experience.

Steps to Reproduce
Steps to reproduce the behavior:

  1. Go to Members or Administrators in the dashboard
  2. Search for a term
  3. Close the modal and re-open it again
  4. See the same search results again

Expected behavior
The search should clear when the modal closes and on re-opening it while staying on the same page search results should not persist.

Screenshots
Peek 2020-09-30 06-28

Desktop (please complete the following information):

  • OS: Ubuntu 20.04
  • Browser Chrome
  • Version 85

Additional context
Hacktoberfest
@ksraj123 ksraj123 added the bug Something isn't working label Sep 30, 2020
@robin828 robin828 linked a pull request Oct 7, 2020 that will close this issue
Open
@robin828
Copy link

robin828 commented Oct 7, 2020

@ksraj123 Please Review

@lazycipher
Copy link

Fixed in: #658

@lazycipher lazycipher mentioned this issue Nov 30, 2020
Merged
@anipaul2
Copy link

How can I contribute to this repo?

@anipaul2
Copy link

Forked the repo and cloned. While doing npm install and npm start showing error "'react-scripts' is not recognized as an internal or external command,
operable program or batch file."

anipaul2 added a commit to anipaul2/social-platform-donut-frontend that referenced this issue Feb 10, 2022
@anipaul2
Fixed issue codeuino#637
114741f
@anipaul2
Copy link

@ksraj123 please review my changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers HACKTOBERFEST
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed Searches persist in Members and Administrators Popup
5 participants
@lazycipher @AuraOfDivinity @ksraj123 @robin828 @anipaul2