Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement google auth #164

Open
nisarg1499 opened this issue Aug 4, 2020 · 4 comments
Open

Implement google auth #164

nisarg1499 opened this issue Aug 4, 2020 · 4 comments
Labels

Comments

@nisarg1499
Copy link

Is your feature request related to a problem? Please describe.
Currently there is no login with google. There can be many users who can just login using google and it can be more convinient.

Describe the solution you'd like
Add login with google. Implement google auth

Additional context
I would be happy to take this issue and implement this.

@victorphoenix3
Copy link

@jaskiratsingh2000 @Rupeshiya If this feature is required, may I submit a PR for implementing this?

@Rupeshiya
Copy link
Member

Hi @victorphoenix3 , Yes you can go ahead, make sure you integrate that to frontend.
Thanks.

@victorphoenix3
Copy link

@Rupeshiya should we prompt the user for password after signing in through google or log them in directly?

@Rupeshiya
Copy link
Member

@victorphoenix3 If you are using passport.js to implement this then just use their name and email etc and yes prompt them for password and then log in directly by varifying in the backend side
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants