Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Login & Signup enhancements #11

Open
vinaypuppal opened this issue Sep 12, 2019 · 1 comment
Open

Login & Signup enhancements #11

vinaypuppal opened this issue Sep 12, 2019 · 1 comment

Comments

@vinaypuppal
Copy link
Contributor

vinaypuppal commented Sep 12, 2019

Describe the bug

  1. No visual feedback like loader when logging in or signing up.
  2. No validation of data or form fields on client-side or server-side. I can create users by submitting below details 馃槻
    Screenshot 2019-09-12 at 10 20 49 PM
  3. In the above screenshot, you can see the signup form has Login header.
  4. Signing up should automatically login user which is better UX

To Reproduce
Steps to reproduce the behavior:

  1. Go to log in or signup page
  2. Try to create user
  3. You can find above-listed issues or bugs

Expected Behaviour

  1. Add a loader when the form is being submitted.
  2. Add client-side form validation and also do same in serverside
  3. Fix signup form header
  4. On backend implement automatically login user when user signs up and reflect same on frontend side also
@vinaypuppal
Copy link
Contributor Author

vinaypuppal commented Sep 13, 2019

@pbteja1998 Please be cautious when adding external NPM packages i.e we should not bloat the app with some many dependencies which might increase bundle size which inturns affect user experience on slow devices and network conditions.

For example, instead of vue-overlay-loader, we can use loading and disabled prop on Button and also disable form fields while the form is getting submitted.

When adding any external dependency please make sure it's lightweight. You can check its impact on user devices here https://bundlephobia.com/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant