Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code not compatible with custom image model #621

Closed
mr-klint opened this issue Feb 10, 2024 · 0 comments · Fixed by #625
Closed

Code not compatible with custom image model #621

mr-klint opened this issue Feb 10, 2024 · 0 comments · Fixed by #625
Labels
Type: Bug Something isn't working
Milestone
3.0.4

Comments

@mr-klint
Copy link

The coderedcms templatetags utilize an import of:

from wagtail.images.models import Image

instead of fetching the currently defined image model from the settings file (by the wagtail function wagtail.images.get_image_model()) and thereby making it incompatible with custom image models.

Im not yet sure if the same type of imports are true also for other files…
@mr-klint mr-klint added the Type: Bug Something isn't working label Feb 10, 2024
This was referenced Feb 15, 2024
Merged
Merged
@vsalvino vsalvino added this to the 3.0.4 milestone Feb 22, 2024
vsalvino pushed a commit that referenced this issue May 18, 2024
@jlchilders11
Close bug 621 use custom image model in tag (#625)
8ea640f 
Change the CRX image tag to use `get_image_model` to follow Wagtail best
practices and allow for custom models

closes #621
@vsalvino vsalvino mentioned this issue May 18, 2024
Closed
vsalvino pushed a commit that referenced this issue May 18, 2024
@jlchilders11 @vsalvino
Close bug 621 use custom image model in tag (#625)
51d8b88 
Change the CRX image tag to use `get_image_model` to follow Wagtail best
practices and allow for custom models

closes #621
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Bug Something isn't working
Projects
None yet
Milestone
3.0.4
Development

Successfully merging a pull request may close this issue.

Close bug 621 use custom image model in tag coderedcorp/coderedcms
2 participants
@vsalvino @mr-klint