Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ArticlePage Templates #572

Open
Zsvoboda87 opened this issue May 9, 2023 · 3 comments
Open

ArticlePage Templates #572

Zsvoboda87 opened this issue May 9, 2023 · 3 comments
Labels
Type: Enhancement New feature or functionality change

Comments

@Zsvoboda87
Copy link
Contributor

Is your feature request related to a problem? Please describe.

If you're using an article page and want to change to different template the content is no longer wrapped in a container causing all the content to fill the whole page without the margins.

Describe the solution you'd like

Possibly more templates, or remove those options on that page model.

Describe alternatives you've considered

I added an if statement on the webpage template checking the page type and conditionally added a container if neccessary

Additional context

This issue came when a client wanted to use a different template on their article page.

@Zsvoboda87 Zsvoboda87 added the Type: Enhancement New feature or functionality change label May 9, 2023
@vsalvino
Copy link
Contributor

Was this an issue using one of the built-in CRX templates? The base template does not use containers for content, allowing the page templates to implement their own structures.

@rosslaird
Copy link
Contributor

rosslaird commented May 15, 2023

Yes, this occurs with the built-in article page template. If a user chooses anything other than Default in the template dropdown for Visual Design, the page loses the container that is provided by the default article page layout. Consequently, options other than Default are somewhat unusable in the context of article pages; they are intended for use by the other page types. So, I think the idea (since this issue arose in the context of my site) is either to remove the layout options for article pages (since they don't work well anyway); or — and preferably — adjust the currently non-functional layout options so that they provide the intended functions of the options within the content containment for article pages. (Another option might be to provide layout options for article pages specifically, such as showcase, editorial, opinion, or journal pages within the article page type.)

@vsalvino
Copy link
Contributor

The use of that dropdown for templates is primarily for the developer to create custom alternate layouts, which can be hooked in to specific page types. However out of the box, we only provide a couple bare-bones options.

So yes the idea of having more templates for an Article is possible. However I don't anticipate we will provide any more out-of-the-box. If you'd like to develop your own, or change what is in that dropdown, you can follow this guide: #44 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement New feature or functionality change
Projects
None yet
Development

No branches or pull requests

3 participants