Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Install script with --stable flag pulls mainline on macOS #13214

Open
stirby opened this issue May 9, 2024 · 2 comments
Open

Install script with --stable flag pulls mainline on macOS #13214

stirby opened this issue May 9, 2024 · 2 comments
Labels
bug Used to filter all bug issues chore Non-customer facing refactors, cleanup, or technical debt. cli Area: CLI must-do Issues that must be completed by the end of the Sprint. Or else. s3 Bugs that confuse, annoy, or are purely cosmetic

Comments

@stirby
Copy link
Collaborator

stirby commented May 9, 2024

On MacOS install.sh --stable uses brew, which installs mainline by default.

We should edit the script to use the stable version number with brew when the --stable flag is passed.
@stirby stirby added chore Non-customer facing refactors, cleanup, or technical debt. must-do Issues that must be completed by the end of the Sprint. Or else. bug Used to filter all bug issues labels May 9, 2024
@coder-labeler coder-labeler bot added cli Area: CLI s3 Bugs that confuse, annoy, or are purely cosmetic labels May 9, 2024
@matifali
Copy link
Collaborator

matifali commented May 9, 2024

macOS defaults to brew which is on mainline. We should either push a stable/mainline brew package and handle that accordingly or change default to GitHub release binaries.

@stirby
Copy link
Collaborator Author

stirby commented May 9, 2024

We're just going to change the install.sh script, adding support for --stable on macOS to close this. We should add another package on homebrew soon too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Used to filter all bug issues chore Non-customer facing refactors, cleanup, or technical debt. cli Area: CLI must-do Issues that must be completed by the end of the Sprint. Or else. s3 Bugs that confuse, annoy, or are purely cosmetic
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@matifali @stirby