Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make fmt failing on main #12954

Closed
matifali opened this issue Apr 13, 2024 · 1 comment · May be fixed by #12921
Closed

make fmt failing on main #12954

matifali opened this issue Apr 13, 2024 · 1 comment · May be fixed by #12921
Labels
bug Used to filter all bug issues s4 Internal bugs (e.g. test flakes), extreme edge cases, and bug risks

Comments

@matifali
Copy link
Collaborator

matifali commented Apr 13, 2024 •
edited

Looks like xterm has migrated its packages to @xtrem scope and no longer works with old package names and imports:

https://github.com/xtermjs/xterm.js/releases/tag/5.4.0

Running make fmt on the main branch produces the following error.

make fmt
==> fmt/eslint

> coder-v2@ lint:fix /home/coder/repos/coder/coder/site
> eslint --fix e2e/ src/


/home/coder/repos/coder/coder/site/src/pages/TerminalPage/TerminalPage.tsx
   1:8   error  Unable to resolve path to module 'xterm/css/xterm.css'    import/no-unresolved
   8:24  error  Unable to resolve path to module 'xterm'                  import/no-unresolved
   9:29  error  Unable to resolve path to module 'xterm-addon-canvas'     import/no-unresolved
  10:26  error  Unable to resolve path to module 'xterm-addon-fit'        import/no-unresolved
  11:32  error  Unable to resolve path to module 'xterm-addon-unicode11'  import/no-unresolved
  12:31  error  Unable to resolve path to module 'xterm-addon-web-links'  import/no-unresolved
  13:28  error  Unable to resolve path to module 'xterm-addon-webgl'      import/no-unresolved

✖ 7 problems (7 errors, 0 warnings)

 ELIFECYCLE  Command failed with exit code 1.
make: *** [Makefile:400: fmt/eslint] Error 1
@coder-labeler coder-labeler bot added bug Used to filter all bug issues site Area: frontend dashboard labels Apr 13, 2024
@matifali matifali mentioned this issue Apr 13, 2024
Draft
@matifali matifali added s4 Internal bugs (e.g. test flakes), extreme edge cases, and bug risks and removed site Area: frontend dashboard labels Apr 13, 2024
@matifali
Copy link
Collaborator Author

This does not fail on main. I was running make fmt while I had npm packages insatlled from a newer node20 branch where the package names are different.

@matifali matifali closed this as not planned Won't fix, can't repro, duplicate, stale Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Used to filter all bug issues s4 Internal bugs (e.g. test flakes), extreme edge cases, and bug risks
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: update Node.js version to 20.x coder/coder
1 participant
@matifali