Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Photo upload screen when reporting a problem - remove image button and thumbnail style and size #153

Open
schlos opened this issue Oct 21, 2021 · 1 comment
Labels
🕷️ bug Something isn't working help wanted Extra attention is needed html/css js

Comments

@schlos
Copy link
Member

schlos commented Oct 21, 2021

Describe the bug

Photo upload UI/UX when reporting a problem - "remove image" button not displayed properly overlayed on image. See screenshot.

To Reproduce
Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior

Following Figma design and functionality on other FMS themes.

Screenshots

Current (photo buttons after it's uploaded in report a new problem flow):
Screenshot from 2021-10-21 16-59-41

For comparison - good example ("remove image" button is overlayed over photo, other theme shown for comparison):
Screenshot from 2021-10-21 17-20-12

Expected (Figma photo thumbnails - should be consistent size size like on report details screen):
Screenshot from 2021-10-21 17-24-21

Figma - report details screen showing 3 photo thumbnails:
https://www.figma.com/proto/OrvZfg5BsfdOzeL7nhRpEI/Popravi.to?node-id=2764%3A12190&scaling=min-zoom&page-id=25%3A186&hide-ui=1

Desktop (please complete the following information):

  • OS: [e.g. Windows]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Additional context

Relevant part in the code:
https://github.com/codeforcroatia/popravi.to/blob/develop/templates/web/popravito/report/new/form_report.html#L95

@schlos schlos added 🕷️ bug Something isn't working help wanted Extra attention is needed labels Oct 21, 2021
@schlos schlos added this to Backlog in Popravi.to priorities Nov 12, 2021
@schlos schlos changed the title popravito: Photo upload screen when reporting a problem - remove image button and thumbnail style and size Photo upload screen when reporting a problem - remove image button and thumbnail style and size Nov 26, 2021
@schlos
Copy link
Member Author

schlos commented Nov 26, 2021

How to contribute?
Read our contribution guidelines at https://codeforcroatia.org/popravito-contribution-guidelines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🕷️ bug Something isn't working help wanted Extra attention is needed html/css js
Projects
Development

No branches or pull requests

1 participant