Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map has wrong size on Report details screen #152

Open
schlos opened this issue Oct 17, 2021 · 2 comments
Open

Map has wrong size on Report details screen #152

schlos opened this issue Oct 17, 2021 · 2 comments
Labels
🕷️ bug Something isn't working help wanted Extra attention is needed html/css

Comments

@schlos
Copy link
Member

schlos commented Oct 17, 2021

Describe the bug

Map has wrong size on Report details screen (see under screesnhots).

To Reproduce
Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior

As per Figma design:

Map on Report details screen should be fixed to visible part of a screen and non scrollable (on Desktop).
Text details on left side of a screen should be possible to scroll is there is content that does not fit on a visible part of a screen - see example on a FixMyStreet:

Screenshots

Current problem with map size:

Screenshot from 2021-10-17 15-00-17

Desktop (please complete the following information):

  • OS: [e.g. Windows]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Additional context

First development version with static HTML can be fetched on our internal drive (this screen is report_details.html):
https://drive.google.com/file/d/1wS_feNEopHBk9Ji2u66Bex3okye27azd/view?usp=sharing

@schlos schlos added 🕷️ bug Something isn't working help wanted Extra attention is needed labels Oct 17, 2021
@schlos schlos added the html/css label Nov 6, 2021
@schlos
Copy link
Member Author

schlos commented Nov 7, 2021

For working reference, refer to the original FMS web and how it's working as a progressive mobile app and how map is displayed on a mobile screen:
mysociety#1996 (comment)

@schlos schlos added this to Backlog in Popravi.to priorities Nov 12, 2021
@schlos schlos changed the title popravito: Map has wrong size on Report details screen Map has wrong size on Report details screen Nov 26, 2021
@schlos
Copy link
Member Author

schlos commented Nov 26, 2021

How to contribute?
Read our contribution guidelines at https://codeforcroatia.org/popravito-contribution-guidelines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🕷️ bug Something isn't working help wanted Extra attention is needed html/css
Projects
Development

No branches or pull requests

1 participant