Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unorderd lists needs CSS fix for mobile view (FAQ page) #137

Open
schlos opened this issue Oct 3, 2021 · 3 comments
Open

Unorderd lists needs CSS fix for mobile view (FAQ page) #137

schlos opened this issue Oct 3, 2021 · 3 comments
Labels
🕷️ bug Something isn't working help wanted Extra attention is needed html/css

Comments

@schlos
Copy link
Member

schlos commented Oct 3, 2021

Describe the bug

Unorderd lists needs CSS fix for mobile view (see screenshot).

To Reproduce
Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior

Alignment and margins for all bullets should be the same on mobile like on desktop.

Screenshots

Current problem on mobile:

photo_2021-10-03_10-38-19

Current expected on desktop (same should be applied to mobile):
https://snippyly.com/img/?q=hNfQHvTv0DkDhSTMUv9n

Desktop (please complete the following information):

  • OS: [e.g. Windows]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Additional context

This bug is related to fix done on #134 (which fixed it for desktop).

Possible culprit is base.scss:1042 (applied on <ul>):

.two-col-left *:not(:first-child) {
    padding: 0 1.5rem 0 1.5rem;
}
@schlos schlos added 🕷️ bug Something isn't working help wanted Extra attention is needed labels Oct 3, 2021
@schlos schlos changed the title popravito: Unorderd lists needs CSS fix for mobile view popravito: Unorderd lists needs CSS fix for mobile view (FAQ page) Oct 3, 2021
@schlos schlos added this to Backlog in Popravi.to priorities Nov 12, 2021
@schlos schlos changed the title popravito: Unorderd lists needs CSS fix for mobile view (FAQ page) Unorderd lists needs CSS fix for mobile view (FAQ page) Nov 26, 2021
@schlos
Copy link
Member Author

schlos commented Nov 26, 2021

How to contribute?
Read our contribution guidelines at https://codeforcroatia.org/popravito-contribution-guidelines.

@znmustic
Copy link

znmustic commented Jun 7, 2023

Preuzimam

znmustic added a commit to znmustic/popravi.to that referenced this issue Sep 26, 2023
schlos added a commit that referenced this issue Sep 26, 2023
@schlos
Copy link
Member Author

schlos commented Sep 26, 2023

Done by Zdenka. Needs testing before closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🕷️ bug Something isn't working help wanted Extra attention is needed html/css
Projects
Status: In Progress
Development

No branches or pull requests

2 participants